Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ExecuteDelete: Always generate Any form #28781

Merged
merged 3 commits into from
Aug 19, 2022
Merged

ExecuteDelete: Always generate Any form #28781

merged 3 commits into from
Aug 19, 2022

Conversation

smitpatel
Copy link
Contributor

Visit retrived ProjectionBinding from select expression as projection binding can bind to non-SqlExpression too.

Resolves #28524
Resolves #28745
Resolves #28752

@smitpatel smitpatel requested a review from a team August 18, 2022 22:12
roji
roji approved these changes Aug 19, 2022
View reviewed changes
Copy link
Member

@roji roji left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Understanding a bit less but that is not preventing me from pushing approve!

🐑 🇮🇹

test/EFCore.Relational.Specification.Tests/BulkUpdates/FiltersInheritanceBulkUpdatesTestBase.cs Show resolved Hide resolved
@smitpatel
Copy link
Contributor Author

Majorly there are 2 changes here

  • We moved processing of ShapedQueryExpression from VisitMethodCall to VisitExtension. This has moved back & forth few times. The bottom line is, VisitMethodCall only works if we send expression from outside which contains ShapedQueryExpression which is composed upon using queryable method call which would be translated as subquery. In any other case it doesn't work but that is not required limitation. Second point makes it even more obvious.
  • Now we visit the projection we get from SelectExpression. A mapped projection can also be subquery (which can be lifted), (potentially JSON) so we need to visit it.

@smitpatel
ExecuteDelete: Always generate Any form
5857067 
Visit retrived ProjectionBinding from select expression as projection binding can bind to non-SqlExpression too.

Resolves #28524
Resolves #28745
Resolves #28752
@smitpatel
Add support for TagWith on ExecuteDelete/Update (#28782)
be33de6 
Resolves #28690
@smitpatel
ExecuteUpdate: Implement support for DEFAULT (#28784)
7107cf0 
Resolves #28660
@roji
Copy link
Member

roji commented Aug 19, 2022

Thanks for the explanation @smitpatel

@smitpatel smitpatel merged commit 7107cf0 into release/7.0 Aug 19, 2022
@smitpatel smitpatel deleted the smit/something branch August 19, 2022 21:50
@ajcvickers ajcvickers mentioned this pull request Sep 1, 2022
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@roji roji roji approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
2 participants
@smitpatel @roji